Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes postgres sequence reset #3340

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Fixes postgres sequence reset #3340

merged 2 commits into from
Mar 10, 2025

Conversation

alishakawaguchi
Copy link
Contributor

Since we create sequences first then tables in init schema the sequence names don't match the source db. Update postgres sequence reset to query destination instead of source for sequences to reset

@alishakawaguchi alishakawaguchi added the bug Something isn't working label Mar 10, 2025
@alishakawaguchi alishakawaguchi self-assigned this Mar 10, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 6:35pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

Benchstat Geomean Results

0.36% sec/op, -0.02% B/op, 0.00% allocs/op

Benchstat results 
                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │       sec/op       │    sec/op      vs base              │
CleanPostgresType-4                         42.63n ± 4%   42.34n ± 117%       ~ (p=0.461 n=6)
Runner_Single-4                             7.713µ ± 5%   7.812µ ±   2%       ~ (p=0.394 n=6)
GenerateBool-4                              11.45n ± 1%   11.36n ±   1%       ~ (p=0.091 n=6)
GenerateBusinessName-4                      285.4n ± 0%   292.1n ±  20%  +2.35% (p=0.004 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.38n ±   0%       ~ (p=0.331 n=6)
GenerateCategorical-4                       104.1n ± 2%   102.9n ±   0%  -1.20% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%   172.5n ±   3%       ~ (p=0.058 n=6)
GenerateCountry-4                           105.2n ± 1%   107.1n ±   1%  +1.81% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.349µ ±   1%       ~ (p=0.104 n=6)
GenerateFirstName-4                         203.9n ± 0%   202.5n ±   1%  -0.69% (p=0.045 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.80n ±   0%       ~ (p=0.180 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.437µ ±   4%       ~ (p=0.180 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.260µ ±   2%  +3.11% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%   41.52n ±   1%       ~ (p=0.074 n=6)
GenerateInt64-4                             28.41n ± 2%   28.28n ±   1%       ~ (p=0.818 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.31n ±   0%       ~ (p=0.567 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   175.1n ±   2%       ~ (p=0.084 n=6)
GenerateIpAddress-4                         569.3n ± 0%   522.2n ±   1%  -8.27% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   190.0n ±   0%  +1.36% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   982.5n ±   1%       ~ (p=0.394 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.022µ ±   1%  +0.59% (p=0.002 n=6)
GenerateSSN-4                               305.8n ± 1%   304.3n ±   1%       ~ (p=0.084 n=6)
GenerateState-4                             105.2n ± 2%   105.3n ±   0%       ~ (p=0.437 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   206.1n ±   0%  +1.08% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   180.1n ±   0%  +0.45% (p=0.004 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.33n ±   2%       ~ (p=0.195 n=6)
GenerateUsername-4                          351.5n ± 0%   360.0n ±   2%  +2.42% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.3n ±   2%       ~ (p=0.965 n=6)
GenerateUUID-4                              734.0n ± 0%   752.4n ±   1%  +2.51% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   106.3n ±   1%       ~ (p=0.069 n=6)
TransformCharacterScramble-4                171.8n ± 1%   171.3n ±   0%       ~ (p=0.258 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   180.4n ±   1%       ~ (p=0.851 n=6)
TransformEmail-4                            1.798µ ± 2%   1.807µ ±   0%       ~ (p=0.093 n=6)
TransformFirstName-4                        233.9n ± 0%   239.6n ±   1%  +2.46% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%   111.0n ±   0%       ~ (p=1.000 n=6)
TransformFullName-4                         1.235µ ± 2%   1.295µ ±   3%  +4.90% (p=0.004 n=6)
TransformInt64-4                            33.74n ± 1%   33.61n ±   0%       ~ (p=0.394 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   57.99n ±   1%       ~ (p=0.195 n=6)
TransformLastName-4                         191.6n ± 0%   195.4n ±   0%  +1.98% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%   1.028µ ±   0%  +0.59% (p=0.002 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   209.6n ±   1%  -0.64% (p=0.028 n=6)
TransformUuid-4                             36.54n ± 1%   36.76n ±   1%  +0.62% (p=0.009 n=6)
geomean                                     194.0n        194.7n         +0.36%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.291Ki ± 3%       ~ (p=0.065 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 3%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@alishakawaguchi alishakawaguchi merged commit dd7dd4e into main Mar 10, 2025
13 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/postgres-sequences-bug branch March 10, 2025 18:52
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 24.65%. Comparing base (b2047e9) to head (60646cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...run-sql-init-table-stmts/init-statement-builder.go 20.00% 7 Missing and 1 partial ⚠️
...ackend/pkg/sqlmanager/postgres/postgres-manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   24.66%   24.65%   -0.01%     
==========================================
  Files         395      395              
  Lines       45872    45872              
==========================================
- Hits        11313    11311       -2     
- Misses      33439    33440       +1     
- Partials     1120     1121       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BrewTestBot BrewTestBot mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickzelei nickzelei nickzelei approved these changes

Assignees

@alishakawaguchi alishakawaguchi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alishakawaguchi @nickzelei